Add cronjob for readreplica rotator #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[WARNING:INTCFG] Changes in |
hlts2
reviewed
Dec 6, 2023
| @@ -0,0 +1,59 @@ | |||
| # | |||
There was a problem hiding this comment.
Could you please also add NetworkPolicy resource?? 🙏
There was a problem hiding this comment.
Thank you for pointing out.
6544457
hlts2
reviewed
Dec 6, 2023
vankichi
previously approved these changes
Dec 6, 2023
vankichi
approved these changes
Dec 6, 2023
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Implement sample read replica rotation logic * Add external-snapshotter in go.mod * Add readreplica initial implementation * Add service implementation of readreplica rotator * Add readreplica rotate config * Refactor to read labels * replace id to _MY_TARGET_REPLICA_ID_ * Add snapshot k8s client * Format * Fix snapshot client initialization * Add Apache License to main.go * Use GetConfigOrDie * Use internal/k8s client * Refactor * Use controller-runtime for CRUD in readreplica * Remove snapshot client and use controller-runtime * Move LabelSelector into internal/k8s * Report error to span * Update go modules * Remove old example * Refactor * Disable exhaustruct for now * Fix predeclared * Fix stylecheck * nolint:gomnd * Add test template * Add test for getNewBaseName * Add readreplica-rotate build scripts * Add service account and clusterroles for read replica rotator * Update charts * Update comment * update charts * Update docker image name in Makefile.d/docker.mk * Fix scheme * Update docs * Fix comment * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 6dba952 according to the output from Gofumpt and Prettier. Details: #2242 * Fix indent * Add network policy for readreplica rotator * Update README.md --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add docker image and cronjob helm template for #2241.
To add e2e tests for this, read replica deployment helm template is required. I'll do this in another PR.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: